Skip to content

stream: fix nested compose error propagation#62556

Open
mcollina wants to merge 2 commits intonodejs:mainfrom
mcollina:fix-compose-60083
Open

stream: fix nested compose error propagation#62556
mcollina wants to merge 2 commits intonodejs:mainfrom
mcollina:fix-compose-60083

Conversation

@mcollina
Copy link
Copy Markdown
Member

@mcollina mcollina commented Apr 2, 2026

Fixes: #60083

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. labels Apr 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (53bcd11) to head (32916e9).
⚠️ Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main   #62556     +/-   ##
=========================================
  Coverage   89.70%   89.71%             
=========================================
  Files         678      695     +17     
  Lines      207195   214545   +7350     
  Branches    39730    41078   +1348     
=========================================
+ Hits       185862   192471   +6609     
- Misses      13438    14119    +681     
- Partials     7895     7955     +60     
Files with missing lines Coverage Δ
lib/internal/streams/duplexify.js 96.91% <100.00%> (+0.34%) ⬆️
lib/internal/streams/from.js 86.75% <100.00%> (+1.18%) ⬆️

... and 120 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors in composed streams hang since Node 22.5

4 participants